fix: use var_{id} as local variable name to avoid the name conflict with tuple struct #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we will generate the enum type in thrift as newtype in rust, that is a tuple struct, there comes a compile error that
let bindings cannot shadow tuple structs
when the field name in idl is same as the tuple struct.For example, the idl below
Solution
We will generate a local variable name with the new rule
var_{field.id}
rather than the rust name of the field to avoid the conflict.